Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand selection to tag doesn't work #47

Closed
Jeloi opened this issue Aug 3, 2014 · 7 comments

Comments

Projects
None yet
4 participants
@Jeloi
Copy link

commented Aug 3, 2014

Expanding selection to tag doesn't work when I set the syntax to be a Handlebars template.

The specific command is:
command: expand_selection {"to": "tag"}

which i have bound to cmd+shift+a.

@daaain

This comment has been minimized.

Copy link
Owner

commented Aug 30, 2014

This seems to be related to #48, I guess the selection doesn't happen because the tag scope is not highlighted.

Unfortunately I can only say the same thing as on #48, no idea how to make this tag pair highlighting work but if you have any pointers I'm happy to reopen and discuss!

@daaain daaain closed this Aug 30, 2014

@designorant

This comment has been minimized.

Copy link

commented Sep 5, 2014

Workaround

Emmet comes with Match Tag Pair that works in similar way, as long as your cursor is within the tag. If you use OSX, the shortcut is ctrl+d.

On a side note, this shouldn't really be closed just because we don't know how to solve it yet.

@daaain

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2014

And again, thanks @designorant and you're right, I'll reopen in case someone can chime in with some pointers!

@daaain daaain reopened this Sep 5, 2014

@daaain daaain referenced this issue Sep 16, 2014

Closed

Tag auto-closing #49

@daaain daaain added the HTML tags label Sep 16, 2014

@msantoro12

This comment has been minimized.

Copy link

commented Mar 17, 2015

Just thought I would let you know I am having this truly annoying problem as well. I was looking into it a bit, but since I have never written a language definition before, have only been able to do comparisons with other packages that work properly.

I have been using the Package​Resource​Viewer to view a number of other included language packages that are functioning as expected. I have looked at the HTML(Rails) definition and think maybe you should look into that approach as well as a stand alone Handlebars definition.

@daaain

This comment has been minimized.

Copy link
Owner

commented Mar 25, 2015

Hey @msantoro12, I had a look, this PackageResoureViewer is basically just a shortcut to open files in installed packages as far as I can see.

I don't have HTML(Rails) language definition, which package does it come from?

@msantoro12

This comment has been minimized.

Copy link

commented Apr 15, 2015

Yes it is an easy way to view compressed packages in sublime quickly. Truthfully I think any HTML(LANG) would be a good example seeing as they are extending the existing HTML language syntax and handling.

@daaain

This comment has been minimized.

Copy link
Owner

commented Dec 13, 2015

I've added the Emmet package workaround to the README (thanks @designorant). Closing the issue as it's very unlikely that I'll ever get around to work on this given that there's a solution (and this issue is referenced from the README now), but of course PRs are still welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.