Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Style fixes to help keyboard navigation #559
Hello! Thank you for making such a nice free theme available. I noticed there were a couple of small fixes I could make to improve accessibility and keyboard navigation. My proposed changes:
Thanks again and looking forward to your thoughts on this!
Thanks for the great PR Katie (and also for your breakup advice site - "If you loved the wrong person this much, think how much you can love the right person", good service to a lot of people!)
Do you have your proposed changes implemented in a demo website where I can see exactly what it would look like?
By just looking at the code, I'm 100% happy with the second change that makes menus tab-able, neat. The first change because it would affect everyone, I'd want to see what it looks like. I certainly wasn't thinking about this sort of accessibility when I agreed to remove the hover effect on the menu button #256 (comment)
As for the
Let me know if you prefer just the