Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing a context provider #101

Closed
matinzd opened this issue Sep 2, 2022 · 8 comments
Closed

Providing a context provider #101

matinzd opened this issue Sep 2, 2022 · 8 comments

Comments

@matinzd
Copy link

matinzd commented Sep 2, 2022

I think it can be a good idea to provide a context provider in order to move suggestion rendering out of the container itself.
Imagine you are having a comment input and a send button next to it. For example:

Screenshot 2022-09-02 at 15 28 00

@matinzd matinzd changed the title Provide context provider Providing a context provider Sep 2, 2022
@fukemy
Copy link

fukemy commented Sep 19, 2022

why not use scrollView?

@matinzd
Copy link
Author

matinzd commented Sep 19, 2022

why not use scrollView?

What do you mean?

@fukemy
Copy link

fukemy commented Sep 19, 2022

i think better is keep rendering view inside mentionView better(avoid memories, better handling). And you can wrap the mentionView by scrollView + give maxheight to it.

But for your issues, you can refer to v3 alpha then look how it work

@matinzd
Copy link
Author

matinzd commented Sep 19, 2022

i think better is keep rendering view inside mentionView better(avoid memories, better handling). And you can wrap the mentionView by scrollView + give maxheight to it.

But for your issues, you can refer to v3 alpha then look how it work

I mean we can move rendering the whole list out of component and have some kind of context to get the render suggestions.
I may send a PR for my proposal.

@fukemy
Copy link

fukemy commented Sep 19, 2022

Please double check the v3-alpha, he did all your purpose.

  1. No need to use MentionInput directly
  2. Keep track to mentions suggest
  3. Render mention view in every place you want

@fukemy
Copy link

fukemy commented Sep 19, 2022

#75 (comment)

@matinzd
Copy link
Author

matinzd commented Sep 19, 2022

#75 (comment)

Nice! I didn’t see that.
That is what I wanted :)

@dabakovich
Copy link
Owner

Closing the issue as it seems that v3 resolves the issues described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants