Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternate locations for .imgbotconfig #49

Closed
dabutvin opened this issue Oct 31, 2017 · 5 comments
Projects

Comments

@dabutvin
Copy link
Owner

@dabutvin dabutvin commented Oct 31, 2017

see facebook/react-native#16591 (comment)

today we are pinned to the root of the repo, but there's no reason we can't look in other places.

@mlissner

This comment has been minimized.

Copy link

@mlissner mlissner commented Nov 6, 2017

Seems fine to me. Does Travis support this?

@dabutvin

This comment has been minimized.

Copy link
Owner Author

@dabutvin dabutvin commented Nov 6, 2017

I don't think Travis will let you put your config anywhere else but root.

The contributing.md as an example can go in root, docs, or .github folder.

As people use more and more bots I think a bots folder or something like that will become more prevalent.

I don't see this as a high priority item, but a relatively simple one - especially for a first time contributor.

@mlissner

This comment has been minimized.

Copy link

@mlissner mlissner commented Nov 6, 2017

If I were you, I'd just follow Travis's lead on this one. You might find a nice solution for this, but Travis will find their own eventually, which will undoubtedly be different from yours. Then you'll be the weird one, since Travis is so much more popular.

@dabutvin

This comment has been minimized.

Copy link
Owner Author

@dabutvin dabutvin commented Nov 8, 2017

I'm inclined to agree with you :)

@dabutvin dabutvin closed this Nov 8, 2017
@dabutvin dabutvin added this to Done issues in ImgBot Jul 28, 2018
Repository owner deleted a comment Sep 26, 2018
@Thezone1975

This comment has been minimized.

Copy link

@Thezone1975 Thezone1975 commented May 26, 2019

;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ImgBot
  
Done issues
3 participants
You can’t perform that action at this time.