Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various spelling and grammar issues for items and descriptions #2

Closed
Wandering-Heiho opened this issue Nov 6, 2020 · 4 comments
Closed

Comments

@Wandering-Heiho
Copy link

@Wandering-Heiho Wandering-Heiho commented Nov 6, 2020

First off, great job so far with polishing up the English patch.
This is just a list of incorrect spelling and grammar I found when going through ingredients, equipment, achievements, food, and enemy info.

NPJH50625_00001
the word "where" doesn't work here. I think either removing it or changing it to "well" would flow better.

NPJH50625_00002
I personally feel there should be a period after the word "injuries", as the way it is now could be misinterpreted to be about a group of mountain climbers that weaponized injuries.

NPJH50625_00003
I've always felt this description was a little clunky. Maybe have the second sentence be "Makes your body feel like it can float." would work better?

NPJH50625_00004
Nothing exactly wrong with this description, except for the fact that the achievement also requires all equipment in addition to weapons.

NPJH50625_00005
"Especially" is misspelled as "Expecially".

NPJH50625_00006
So I noticed you changed the name for one of the foods called "Fish Fry" so they would be unique. Since there is another food called "Meat Bun", this one might be better being called "Steak Bun" based on its description.

Last note about foods, I noticed you changed the food "Box Lunch" to "Boxed Lunch". This is slightly inconsistent with the recipes "Quality Tartare", "Solid Liver Lunch", "Jungle Rice", "Royal Paella", "Fermented Meat", "Noble Rib Box Lunch", and "Gorgeous Box Lunch", which either use the term box lunch in their name or description. Not entirely sure it this was intentional.
This is also the case with the event item gotten during the prologue called "Eartha's Box Lunch".

NPJH50625_00016
From what I can find, "threaning" is not a word. Was this supposed to be "threatening", or something else?

NPJH50625_00017
"it" should be "its".

NPJH50625_00018
Not sure if this one can be changed or not, but the text in the sub-menu during chapter 5 refers to Creha with the original translation name of Kureha.

And that's all I could find at this time. Apologies for the length of this post.

@dackst
Copy link
Owner

@dackst dackst commented Nov 6, 2020

Yeah, I admit I didn't pay as much attention to changing the item and monster descriptions as I did for other things like the script, and some of these were introduced from what I did change.

I ran into the same thing with the sub-menu text. It only occurs if you load a save from the original translation (or from the unmodified game in Japanese). If you continue to the next objective, it should use the correct text. It appears that the current objective is loaded directly from your save file.

Everything you else mentioned here should be fixed with my next commit.

@Wandering-Heiho
Copy link
Author

@Wandering-Heiho Wandering-Heiho commented Nov 6, 2020

Good to know about the sub-menu text when loading a save file from the original translation, I probably should've tested getting to that point instead of using an old save file.

One more thing I forgot, although one of the sword arts' name was changed to Whirlwind (the upgraded Kamaitachi), the image for when you unlock it still refers to it as Divine Wind.
h_050_02
This image's location is visual -> help and file name is h_050_02.itp
Thankfully, there is a version of the image with no text on the right side, so keeping the background texture should not be as difficult to do (the file is in the same place and is called h_050_01.itp).

dackst added a commit that referenced this issue Nov 7, 2020
@dackst
Copy link
Owner

@dackst dackst commented Nov 7, 2020

I don't think I change any of the skill names. In this case it would be easier to just change "Whirlwind" to "Divine Wind".

@Wandering-Heiho
Copy link
Author

@Wandering-Heiho Wandering-Heiho commented Nov 7, 2020

Yeah, that makes sense.

@dackst dackst closed this Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants