New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for default settings in schema #328

Closed
jimlambie opened this Issue Sep 18, 2017 · 0 comments

Comments

2 participants
@jimlambie
Copy link
Member

jimlambie commented Sep 18, 2017

Expected behavior

When POSTing to a config endpoint with a schema, the settings block should not be validated.

Actual behavior

The schema is validated to ensure settings exist for 'cache', 'authenticate', 'callback', 'defaultFilters', 'fieldLimiters', 'count'. Each of these can be set to a default in the model instead.

https://github.com/dadi/api/blob/master/dadi/lib/help.js#L249

Package details

API all versions

@jimlambie jimlambie self-assigned this Sep 18, 2017

@jimlambie jimlambie added this to Backlog in API Version 3.0 Sep 24, 2017

@jimlambie jimlambie added this to In progress in API Roadmap Sep 24, 2017

@jimlambie jimlambie moved this from In progress to Backlog in API Roadmap Sep 24, 2017

@jimlambie jimlambie moved this from Backlog to In Progress in API Version 3.0 Oct 25, 2017

@jimlambie jimlambie moved this from In Progress to Ready for Release in API Version 3.0 Oct 25, 2017

@jimlambie jimlambie closed this Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment