New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CORS by default #438

Closed
eduardoboucas opened this Issue Jun 20, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@eduardoboucas
Copy link
Member

eduardoboucas commented Jun 20, 2018

I think we should make the cors config property enabled by default. It's expected that using API from a client-side application will be a very common use case, which requires developers to explicitly enable CORS in their API configs. I don't see any harm in making that enabled by default.

https://github.com/dadi/api/blob/develop/config.js#L360

What do you think @jimlambie?

@danwdart

This comment has been minimized.

Copy link
Contributor

danwdart commented Jun 27, 2018

Should this now be closed?

@eduardoboucas

This comment has been minimized.

Copy link
Member Author

eduardoboucas commented Jun 27, 2018

Indeed! Thanks @danwdart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment