Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Model API #399

Merged
merged 66 commits into from Apr 5, 2018

Conversation

Projects
None yet
3 participants
@eduardoboucas
Copy link
Member

eduardoboucas commented Mar 22, 2018

Closes #157.
Closes #177.
Closes #196.
Closes #300.
Closes #323.
Closes #329.
Closes #336.
Closes #390.
Closes #394.

eduardoboucas added some commits Apr 4, 2018

<html>

This comment has been minimized.

@jimlambie

jimlambie Apr 4, 2018

Member

@eduardoboucas this is obviously incorrect, but my preference for this file would be to remove and ignore it in the repo

This comment has been minimized.

@eduardoboucas

eduardoboucas Apr 4, 2018

Author Member

Agree!

This comment has been minimized.

@eduardoboucas

eduardoboucas Apr 5, 2018

Author Member

@jimlambie
Copy link
Member

jimlambie left a comment

I'm 99.999999999% sure this is correct. I like and approve. Currently testing against a couple of projects. Happy for merge to proceed.

@eduardoboucas

This comment has been minimized.

Copy link
Member Author

eduardoboucas commented Apr 4, 2018

I'm 99.999999999% sure this is correct. I like and approve. Currently testing against a couple of projects. Happy for merge to proceed.

Yay, thanks! I'm just doing some final fixes and adding some more tests, will merge once done.

@eduardoboucas eduardoboucas merged commit 9d913e6 into develop Apr 5, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details

@eduardoboucas eduardoboucas deleted the feature/new-model-api branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.