New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config endpoints #449

Merged
merged 9 commits into from Jul 6, 2018

Conversation

Projects
None yet
3 participants
@eduardoboucas
Copy link
Member

eduardoboucas commented Jun 27, 2018

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 3, 2018

Pull Request Test Coverage Report for Build 1354

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • 92 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.3%) to 88.712%

Files with Coverage Reduction New Missed Lines %
dadi/lib/model/acl/matrix.js 1 96.88%
dadi/lib/controller/clients.js 2 92.31%
dadi/lib/model/acl/role.js 8 85.06%
dadi/lib/model/acl/client.js 8 88.24%
dadi/lib/controller/hooks.js 10 84.62%
dadi/lib/help.js 10 86.21%
dadi/lib/model/acl/access.js 15 82.07%
dadi/lib/index.js 38 72.69%
Totals Coverage Status
Change from base Build 1331: -0.3%
Covered Lines: 3196
Relevant Lines: 3505

💛 - Coveralls
@eduardoboucas

This comment has been minimized.

Copy link
Member Author

eduardoboucas commented Jul 4, 2018

@jimlambie This is ready for you 🎁

@jimlambie
Copy link
Member

jimlambie left a comment

Looks great, @eduardoboucas 🎉

@eduardoboucas eduardoboucas merged commit c96152f into develop Jul 6, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 88.724%
Details
security/snyk - package.json (DADI) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment