New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct permissions and status code when a role is revoked #460

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
3 participants
@eduardoboucas
Copy link
Member

eduardoboucas commented Jul 17, 2018

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 17, 2018

Pull Request Test Coverage Report for Build 1392

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 88.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dadi/lib/controller/clients.js 2 3 66.67%
Totals Coverage Status
Change from base Build 1372: 0.004%
Covered Lines: 3198
Relevant Lines: 3507

💛 - Coveralls
1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 17, 2018

Pull Request Test Coverage Report for Build 1392

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 88.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dadi/lib/controller/clients.js 2 3 66.67%
Totals Coverage Status
Change from base Build 1372: 0.004%
Covered Lines: 3198
Relevant Lines: 3507

💛 - Coveralls
@jimlambie
Copy link
Member

jimlambie left a comment

👩

@eduardoboucas eduardoboucas merged commit 894f899 into develop Jul 17, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 88.711%
Details
security/snyk - package.json (DADI) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment