Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search #538

Open
wants to merge 26 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@eduardoboucas
Copy link
Member

eduardoboucas commented Feb 12, 2019

This PR:

  1. Moves dadi/lib/model/search.js to dadi/lib/model/collections/search.js, consistently with other collection methods.
  2. Implements a default search function, compatible with any data connector, to be used if the data connector doesn't provide its own.
  3. Removes the search function from the test connector, in favour of using 2.

More to come. 馃彈

P.S. Ignore the fact that tests are failing on Travis. This piece requires an update to @dadi/api-mongodb, which I haven't committed yet.

@jimlambie
Copy link
Member

jimlambie left a comment

馃尞

jimlambie and others added some commits Feb 19, 2019

Update dadi/lib/fields/boolean.js
Co-Authored-By: jimlambie <jameslambie@gmail.com>
Merge pull request #540 from dadi/patch/boolean-filter-extend-false
Extend a false filter to 鈥渘ot true鈥
Merge branch 'feature/improved-search' of github.com:dadi/api into fe鈥
鈥ture/improved-search

# Conflicts:
#	dadi/lib/controller/index.js
#	dadi/lib/controller/search.js
#	dadi/lib/model/collections/create.js
#	dadi/lib/model/collections/delete.js
#	dadi/lib/model/collections/search.js
#	dadi/lib/model/index.js
#	dadi/lib/model/search.js
#	dadi/lib/search/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.