Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specific dynos to be restarted and viewing of dyno list and status #16

Merged
merged 10 commits into from Jun 11, 2015

Conversation

chaselee
Copy link
Contributor

Allows for the following types of commands:

  • hubot heroku restart my-app (restarts all dynos on app)
  • hubot heroku restart my-app worker (restarts all worker dynos)
  • hubot heroku restart my-app web.2 (restarts only the web.2 dyno)

Chase Lee added 2 commits May 22, 2015 12:11
Allows for the following types of commands:

- `hubot heroku restart my-app` (restarts all dynos on app)
- `hubot heroku restart my-app worker` (restarts all worker dynos)
- `hubot heroku restart my-app web.2` (restarts only the web.2 dyno)
@chaselee
Copy link
Contributor Author

@daemonsy let me know your thoughts!

@chaselee
Copy link
Contributor Author

chaselee commented Jun 2, 2015

@daemonsy, added tests. should be good to go.

@@ -11,7 +11,7 @@
# hubot heroku info <app> - Returns useful information about the app
# hubot heroku releases <app> - Latest 10 releases
# hubot heroku rollback <app> <version> - Rollback to a release
# hubot heroku restart <app> - Restarts the app
# hubot heroku restart <app> <dyno> - Restarts the specified app or dyno/s
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this! It makes sense to do this plus some other commands

  • Check what's the dyno formation for an app
  • Scale web / worker dynos for an app

How about or or here? I haven't had a chance to look into the platform API yet, how do we specify the dyno to be reset? Is it a name or some id? I think it's nice to hint the format in the help message too.

@chaselee chaselee changed the title Allow specific dynos to be restarted Allow specific dynos to be restarted and viewing of dyno list and status Jun 4, 2015
@chaselee
Copy link
Contributor Author

chaselee commented Jun 4, 2015

@daemonsy added another command (w/tests) to get the dyno list. Exactly mimics the Heroku cli ps command. Let me know what you think 😄

@chaselee
Copy link
Contributor Author

chaselee commented Jun 4, 2015

Example output for hubot heroku dynos shield-global-watch:

Damon: Dynos of shield-global-watch
=== web (1X): forever server.js
web.1: up 2015/01/01 07:00:00 (~ 5 months ago)
web.2: crashed 2015/01/01 07:00:00 (~ 5 months ago)

=== worker (2X): celery worker
worker.1: up 2015/06/01 08:00:00 (~ 3 days ago)

@chaselee
Copy link
Contributor Author

chaselee commented Jun 9, 2015

any thoughts @daemonsy?

@daemonsy
Copy link
Owner

👍 Thanks for this, it looks good to me. Merging it and releasing after doing a test internally 😄

daemonsy added a commit that referenced this pull request Jun 11, 2015
Allow specific dynos to be restarted and viewing of dyno list and status
@daemonsy daemonsy merged commit ccd1108 into daemonsy:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants