-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk:rust): remove required syntax around .id().await?
#5670
Conversation
085005a
to
ebcddcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! That's an amazing breaking change.
I would like to hold this PR few days, we should setup changie first (See #5408)
I'll open a PR to setup that for Rust and keep you update
Sounds good. xD |
PR open: #5676 |
@kjuulh PR closed, you can add a release note and I'll merge that PR :D
|
Great! |
ebcddcb
to
67d68b1
Compare
@kjuulh I rebased and added the release note, I'll merge this PR after checks |
I am off of work so I can add a small explanation on what this breaking change means in about 30 min if that id alright? |
Take your time! |
@TomChv Done. I've added a bit more. It seems that the docs are broken though. |
794ce58
to
9890578
Compare
This pr is technically considered a breaking change. More to come before we should schedule a release for rust. This pr primarily removes some required syntactic sugar. let image = client.container().from().with_directory(src.id().await?); // after this pr let image = client.container().from().with_directory(src); This means that the with_directory and other functions like that will no longer accept an ID as argument. I could technically support the other option, but that is somewhat considered an anti pattern, because you opt out of the laziness. What rust sdk does in the background is the same as the other sdks, this means that we've now moved the execution back to the actual api call towards the dagger engine. Instead of doing all these small api calls for caches, volumes, secrets and whatnot in the middle of our execution chain. Signed-off-by: kjuulh <contact@kjuulh.io>
Signed-off-by: Vasek - Tom C <tom@epitech.eu> Signed-off-by: kjuulh <contact@kjuulh.io>
Signed-off-by: kjuulh <contact@kjuulh.io>
9890578
to
3c718cf
Compare
Nvm I will merge the other prs, have the same problem. |
This pr is technically considered a breaking change. More to come before we should schedule a release for rust.
This pr primarily removes some required syntactic sugar.
This means that the with_directory and other functions like that will no longer accept an ID as argument. I could technically support the other option, but that is somewhat considered an anti pattern, because you opt out of the laziness.
What rust sdk does in the background is the same as the other sdks, this means that we've now moved the execution back to the actual api call towards the
dagger engine
. Instead of doing all these small api calls for caches, volumes, secrets and whatnot in the middle of our execution chain.