feat(sdk:rust): remove required syntax around .id().await?
#5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjuulh
force-pushed
the
rust/feat/ids-codegen
branch
2 times, most recently
from
085005a
to
ebcddcb
Compare
|
Sounds good. xD |
|
PR open: #5676 |
|
@kjuulh PR closed, you can add a release note and I'll merge that PR :D
|
|
Great! |
TomChv
force-pushed
the
rust/feat/ids-codegen
branch
from
ebcddcb
to
67d68b1
Compare
|
@kjuulh I rebased and added the release note, I'll merge this PR after checks |
|
I am off of work so I can add a small explanation on what this breaking change means in about 30 min if that id alright? |
Take your time! |
|
@TomChv Done. I've added a bit more. It seems that the docs are broken though. |
kjuulh
force-pushed
the
rust/feat/ids-codegen
branch
from
794ce58
to
9890578
Compare
This pr is technically considered a breaking change. More to come before we should schedule a release for rust. This pr primarily removes some required syntactic sugar. let image = client.container().from().with_directory(src.id().await?); // after this pr let image = client.container().from().with_directory(src); This means that the with_directory and other functions like that will no longer accept an ID as argument. I could technically support the other option, but that is somewhat considered an anti pattern, because you opt out of the laziness. What rust sdk does in the background is the same as the other sdks, this means that we've now moved the execution back to the actual api call towards the dagger engine. Instead of doing all these small api calls for caches, volumes, secrets and whatnot in the middle of our execution chain. Signed-off-by: kjuulh <contact@kjuulh.io>
Signed-off-by: Vasek - Tom C <tom@epitech.eu> Signed-off-by: kjuulh <contact@kjuulh.io>
Signed-off-by: kjuulh <contact@kjuulh.io>
kjuulh
force-pushed
the
rust/feat/ids-codegen
branch
from
9890578
to
3c718cf
Compare
|
Nvm I will merge the other prs, have the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is technically considered a breaking change. More to come before we should schedule a release for rust.
This pr primarily removes some required syntactic sugar.
This means that the with_directory and other functions like that will no longer accept an ID as argument. I could technically support the other option, but that is somewhat considered an anti pattern, because you opt out of the laziness.
What rust sdk does in the background is the same as the other sdks, this means that we've now moved the execution back to the actual api call towards the
dagger engine. Instead of doing all these small api calls for caches, volumes, secrets and whatnot in the middle of our execution chain.