engine: set include and exclude globs deterministically#8471
Merged
marcosnils merged 1 commit intoSep 17, 2024
Merged
Conversation
marcosnils
force-pushed
the
fix/include_exclude_deterministic_order
branch
from
9ad88fe to
86f2188
Compare
marcosnils
requested review from
jedevc,
sipsma and
vito
and removed request for
sipsma
change includeSet and excludeSet to use a slice without duplicates given that the order of the globs is important when calling buildkit. Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
marcosnils
force-pushed
the
fix/include_exclude_deterministic_order
branch
from
86f2188 to
da1b8de
Compare
sipsma
approved these changes
Sep 17, 2024
Contributor
sipsma
left a comment
sipsma
left a comment
There was a problem hiding this comment.
LGTM, this looks like it addresses part of what I mentioned in this comment: #8254 (comment)
Not sure if that entire issue is solved yet, but probably at minimum improved 🎉
It would be nice to have a test here, but it's really quite difficult to test in a deterministic way, so I'm fine merging as is for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change includeSet and excludeSet to use a slice without duplicates given
that the order of the globs is important when calling buildkit.
Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com