llm: avoid exposing the model to "variables" concept - #9993
Merged
Conversation
This was a halfway measure to allowing the LLM to discover vars that were set for it. As-is, it confuses the model into unnecessary calls and into trying to pass variables as arguments to tools, which is a bit too much ambiguity. Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Let's just make everything 100% focused and strictly around IDs, so the model never (lol) tries anything funny. Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
these are fine because the LLM never actually sees them Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
shykes
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bit of a halfway measure and is currently detrimental to consistent model behavior.
For example, I've observed:
readVariableWith this change it will instead be 100% focused on objects and their functions. String variables are always just prompt vars, never exposed to the model.