New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Path-TIny fatpack on perl 5.8 #139

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@brainbuz
Contributor

brainbuz commented Jun 16, 2015

I vendored the abs2rel subroutine to a supporting library and lowered the minimum version of File::Spec to 3.29, which was released prior to 5.8.9 and the lowest I tested on.

The new version passes all tests on perl 5.8.9 (on ubuntu 15.04) and 5.22 (on Mint 17.1). I attempted to run tests on windows with older Strawberry Perls, but had problems with dependencies, settled on Cygwin Perl (which gave me 5.14).

Fatpack seemed to work on the windows instance (File::Spec 3.33) and the Perl 5.8.9 (File::Spec 5.29)

The vendored copy is a fallback so I didn't try to port over any tests for it.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jun 16, 2015

Collaborator

Great! I look forward to checking it out, though that might have to wait a bit while I dig out from the work backlog that built up during YAPC.

Collaborator

ghost commented Jun 16, 2015

Great! I look forward to checking it out, though that might have to wait a bit while I dig out from the work backlog that built up during YAPC.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jun 18, 2015

Collaborator

excellent start. I'm going to close this in favor of 142, which takes it a bit further.

Collaborator

ghost commented Jun 18, 2015

excellent start. I'm going to close this in favor of 142, which takes it a bit further.

@dagolden dagolden closed this Jun 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment