Permalink
Browse files

add note about making Librarian more efficient

  • Loading branch information...
1 parent 3c7b707 commit 764b00738ae6b1006ffc48e3cecb884f3833c234 @xdg xdg committed Sep 28, 2011
Showing with 3 additions and 0 deletions.
  1. +3 −0 lib/Metabase/Librarian.pm
@@ -45,6 +45,9 @@ sub store {
# Don't store existing GUIDs; this should never happen, since we're just
# generating a new one, but... hey, can't be too safe, right?
+ # XXX maybe delegate this down to archive/index, because if they
+ # have unique constraint enforcement, then there's no reason to do
+ # this extra (negative) query
if ( $self->index->exists( $fact->guid ) ) {
Carp::confess("GUID conflicts with an existing object");
}

0 comments on commit 764b007

Please sign in to comment.