Skip to content
Permalink
Browse files

[arc] setup black and eslint linters

Summary:
use pinterests implementations for black and eslint linters https://github.com/pinterest/arcanist-linters

people will need to run `git clone https://github.com/pinterest/arcanist-linters.git pinterest-linters` next to their arcanist installs

depends on D674

Test Plan: manually lint a few files

Reviewers: #ft, max

Reviewed By: #ft, max

Subscribers: max

Differential Revision: https://dagster.phacility.com/D678
  • Loading branch information...
alangenfeld committed Jul 23, 2019
1 parent dda1489 commit 6b5082f6ad69541f7ce7da21d7c076683ea32ce5
Showing with 15 additions and 3 deletions.
  1. +2 −1 .arcconfig
  2. +13 −2 .arclint
@@ -1,3 +1,4 @@
{
"phabricator.uri" : "https://dagster.phacility.com"
"phabricator.uri" : "https://dagster.phacility.com",
"load": ["pinterest-linters"]
}
@@ -1,9 +1,20 @@
{
"linters": {
"repro": {
"pylint": {
"type": "pylint",
"pylint.config": ".pylintrc",
"include": "(\\.py$)"
},
"black": {
"type": "black",
"include": "(\\.py$)",
"black.linelen": 100
},
"eslint": {
"type": "eslint",
"include": "(\\.(ts|tsx)$)",
"bin": "./js_modules/dagit/node_modules/.bin/eslint",
"eslint.config": "./js_modules/dagit/.eslintrc.js"
}
}
}
}

0 comments on commit 6b5082f

Please sign in to comment.
You can’t perform that action at this time.