Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagit resizing seems buggy #1637

Closed
natekupp opened this issue Aug 1, 2019 · 1 comment

Comments

@natekupp
Copy link
Member

commented Aug 1, 2019

Sometimes when resizing a column in the structured log view, the cursor gets stuck in resize mode and I have to click to release:

image

@natekupp natekupp added bug dagit labels Aug 1, 2019

@mgasner

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

We could add a timeout after which the column snaps back to its original position or releases

prha added a commit that referenced this issue Aug 14, 2019

fix column resizing in run view
Summary:
The HTML5 attribute `draggable` on a styled component container was causing the `mouseup` event to get swallowed up.  Renaming the prop (used to key dynamic styles) caused the mouse events to fire as expected.

Refactored some of the document listeners so that they are tied to the component
lifecycle, instead of to UI events.

Issue: #1637

Test Plan: Resized columns in Firefox/Safari/Chrome.

Reviewers: #ft, bengotow, alangenfeld

Reviewed By: bengotow

Subscribers: alangenfeld, max

Differential Revision: https://dagster.phacility.com/D792

@prha prha closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.