Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize natural language instead of cron string #1742

Closed
schrockn opened this issue Sep 11, 2019 · 1 comment

Comments

@schrockn
Copy link
Member

commented Sep 11, 2019

Right now the cron string is always displayed and the english summation is only a tooltip. I think we should lead with the natural text. "Every minute" is in tool tip and the cron string leads:

Screenshot 2019-09-10 19 54 18

And in this case I'm not sure what the 12:00 am signifies even though that is hourly. This could be an unrelated bug.

Screenshot 2019-09-10 19 56 49

@helloworld

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@helloworld helloworld closed this Sep 11, 2019

helloworld added a commit that referenced this issue Sep 11, 2019
Display natural language representation of cron string
Summary:
Displays natural string representation of cron string instead of the cron string in the dagit scheduler UI. See #1742

Also, the cron strings in the examples were set incorrectly (daily instead of hourly)  and are fixed in this diff.

Test Plan:
{F39190}

```
cd /dagster/examples/dagster_examples/experimental
dagit -p 3333
open http://localhost:3000/scheduler
```

Reviewers: #ft, schrockn

Reviewed By: #ft, schrockn

Subscribers: schrockn

Differential Revision: https://dagster.phacility.com/D1008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.