Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate ConfigMappingContext #2023

Closed
schrockn opened this issue Dec 20, 2019 · 0 comments
Closed

Eliminate ConfigMappingContext #2023

schrockn opened this issue Dec 20, 2019 · 0 comments

Comments

@schrockn
Copy link
Member

Depends on #2022
@schrockn schrockn changed the title Eliminate ConfigMappingContext` Eliminate ConfigMappingContext Dec 20, 2019
@mgasner mgasner added the core label Jan 10, 2020
helloworld added a commit that referenced this issue Jan 17, 2020
@helloworld
RFC: Eliminate ConfigMappingContext
2646ae4 
Summary:
Surprisingly, after we removed `execution_epoch_time`, none of the examples throughout the codebase used the `context` on `config_fn`. This diff eliminates `ConfigMappingContext` entirely, since it seems like it's not useful anymore.

Relevant Issues:
#2022
#2023

Test Plan: unit

Reviewers: schrockn, alangenfeld

Reviewed By: schrockn

Differential Revision: https://dagster.phacility.com/D1844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgasner @helloworld @schrockn