Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuiltinDict (_TypedPythonDict) does not have dagster_type_loader #2272

Closed
schrockn opened this issue Mar 14, 2020 · 0 comments
Closed

BuiltinDict (_TypedPythonDict) does not have dagster_type_loader #2272

schrockn opened this issue Mar 14, 2020 · 0 comments
Assignees
@dpeng817
Labels
type: good first issue Good for newcomers

Comments

@schrockn
Copy link
Member

No description provided.

@schrockn schrockn added the type: good first issue Good for newcomers label Mar 14, 2020
@mgasner mgasner added the core label Mar 18, 2020
@natekupp natekupp added this to the 0.9.0 (planned) milestone Jun 1, 2020
@sryza sryza changed the title BuiltinDict (_TypedPythonDict) does not have input_hydration_config BuiltinDict (_TypedPythonDict) does not have dagster_type_loader Aug 11, 2020
@natekupp natekupp modified the milestones: 0.9.0, 0.9.x Sep 16, 2020
@sryza sryza removed this from the 0.9.x milestone Oct 9, 2020
@dpeng817 dpeng817 self-assigned this Oct 23, 2020
dpeng817 added a commit that referenced this issue Nov 2, 2020
@dpeng817
python typeddict type loader
c3af43a 
Summary: There didn't previously exist a DagsterTypeLoader for TypedDict. This creates one, and adds a test to `test_python_dict.py` to ensure proper functioning. (Issue: #2272)

Test Plan: Added `test_dict_type_loader` to tests.

Reviewers: sandyryza, max, alangenfeld

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D4952
dpeng817 added a commit that referenced this issue Nov 3, 2020
@dpeng817
python typeddict type loader
cfd81ca 
Summary: There didn't previously exist a DagsterTypeLoader for TypedDict. This creates one, and adds a test to `test_python_dict.py` to ensure proper functioning. (Issue: #2272)

Test Plan: Added `test_dict_type_loader` to tests.

Reviewers: sandyryza, max, alangenfeld

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D4952

comment change
dpeng817 added a commit that referenced this issue Nov 4, 2020
@dpeng817
python typeddict type loader
84f8a73 
Summary: There didn't previously exist a DagsterTypeLoader for TypedDict. This creates one, and adds a test to `test_python_dict.py` to ensure proper functioning. (Issue: #2272)

Test Plan:
Added `test_dict_type_loader` to tests.
Azure pipeline: https://dev.azure.com/elementl/dagster/_build/results?buildId=9826&view=results

Reviewers: sandyryza, max, alangenfeld

Reviewed By: max

Differential Revision: https://dagster.phacility.com/D5023
@dpeng817 dpeng817 closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpeng817 dpeng817

Labels
type: good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mgasner @natekupp @sryza @dpeng817 @schrockn