Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up temp paths in dagstermill solid #2318

Closed
mgasner opened this issue Mar 24, 2020 · 0 comments
Closed

Clean up temp paths in dagstermill solid #2318

mgasner opened this issue Mar 24, 2020 · 0 comments
Labels
integration: notebook Related to dagstermill type: good first issue Good for newcomers

Comments

@mgasner
Copy link
Contributor

mgasner commented Mar 24, 2020 

base_dir = '/tmp/dagstermill/{run_id}/'.format(run_id=compute_context.run_id)
@mgasner mgasner added integration: notebook Related to dagstermill refactor type: good first issue Good for newcomers labels Mar 24, 2020
mgasner added a commit that referenced this issue Apr 3, 2020
@mgasner
Add the ability to specify that an executed notebook be yielded as an…
bae8a1f 
… output from a dagstermill solid

Summary: This addresses #2319, #2318, and #2110, levering the `FileHandle` machinery.

Test Plan: Unit

Reviewers: alangenfeld, schrockn, nate

Reviewed By: schrockn

Differential Revision: https://dagster.phacility.com/D2431
@mgasner mgasner closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration: notebook Related to dagstermill type: good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgasner