Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc nits and updates #1224

Merged
merged 14 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@mgasner
Copy link
Collaborator

commented Apr 11, 2019

This does three major things

  • It actually builds HTML files with the source for our documented functions. Sphinx had previously been misconfigured so that this was not actually happening.
  • It switches black config to use --line-length 100 everywhere, so that we don't have to try to special case the tutorial code, and slightly alters the Alabaster formatting so this looks better in the built docs.
  • Updates and formats the changelog

@mgasner mgasner requested review from natekupp and schrockn Apr 11, 2019

@mgasner

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 11, 2019

Resolves #1053

@coveralls

This comment has been minimized.

Copy link

commented Apr 11, 2019

Pull Request Test Coverage Report for Build 144600

  • 13 of 13 (100.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.974%

Totals Coverage Status
Change from base Build 142468: 0.0%
Covered Lines: 8010
Relevant Lines: 9105

💛 - Coveralls
@schrockn
Copy link
Member

left a comment

Excellent. Does the long wrapping mess up rendering the code samples at all?

@mgasner

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

I made some changes to our css to mitigate the code sample formatting changes that result from a longer line. Would still rather enforce different lengths, but I think having the pre-commit hook available is better for now given that we need to choose between them until someone takes a look at the pre-commit hook and rewrites it.

@mgasner mgasner merged commit be5a9cb into master Apr 12, 2019

57 checks passed

WIP Ready for review
Details
ci/circleci: airline-demo-py27 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py35 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py36 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py37 Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: dagit-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagit-webapp Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py37 Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py27 Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py35 Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py36 Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py37 Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-sqlalchemy-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-sqlalchemy-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-sqlalchemy-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-sqlalchemy-py37 Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
dagster-io.dagster Build #20190412.40 succeeded
Details

@mgasner mgasner deleted the concept-docs branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.