Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Slack posting resource #1280

Merged
merged 5 commits into from Apr 24, 2019

Conversation

Projects
None yet
4 participants
@natekupp
Copy link
Member

commented Apr 21, 2019

No description provided.

natekupp added some commits Apr 21, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 21, 2019

Pull Request Test Coverage Report for Build 160291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.094%

Totals Coverage Status
Change from base Build 156141: 0.0%
Covered Lines: 8140
Relevant Lines: 9035

💛 - Coveralls
self,
channel='#noise',
username='dagsterbot',
text='https://www.youtube.com/watch?v=dQw4w9WgXcQ',

This comment has been minimized.

Copy link
@mgasner

mgasner Apr 22, 2019

Collaborator

😭

This comment has been minimized.

Copy link
@natekupp

natekupp Apr 23, 2019

Author Member

🎉

@mgasner

This comment has been minimized.

Copy link
Collaborator

commented Apr 22, 2019

The official Slack client uses responses.RequestsMock to test this stuff: https://github.com/slackapi/python-slackclient/blob/master/tests/test_slackclient.py#L172

@natekupp

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@mgasner great find w/ responses; I added a fairly basic test. lmk if you think we should have any others in this first PR

@natekupp natekupp requested a review from schrockn Apr 23, 2019

@schrockn
Copy link
Member

left a comment

looks good

@natekupp natekupp merged commit a4b2f66 into master Apr 24, 2019

55 checks passed

WIP Ready for review
Details
ci/circleci: airline-demo-py27 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py35 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py36 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py37 Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: dagit-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagit-webapp Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-graphql-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py37 Your tests passed on CircleCI!
Details
ci/circleci: docs-snapshot Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py27 Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py35 Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py36 Your tests passed on CircleCI!
Details
ci/circleci: event-pipeline-demo-py37 Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-aws-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-ge-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-pandas-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-snowflake-py37 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py27 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py35 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py36 Your tests passed on CircleCI!
Details
ci/circleci: library-dagster-spark-py37 Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 90.094%
Details
dagster-io.dagster Build #20190424.9 succeeded
Details

@natekupp natekupp deleted the nate/add_slack branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.