[WIP] Reenable Windows GRPC run launcher termination tests #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgasner
force-pushed
the
maybe-fix-windows-tests
branch
from
843f2ee
to
edd78aa
Compare
ajnadel
added a commit
that referenced
this pull request
Jul 10, 2020
Summary: Address windows build failures noted in [[ #2691 | gh#2691 ]]. Changes on this diff are PR'd at [[ #2694 | gh#2694 ]] so that Azure tests run. Azure tests are no longer failing because of azure pipeline issues, but there are unrelated GRPC tests failing on Windows which @max [[ #2696 | is working on. ]] Test Plan: PR to github --> azure Reviewers: alangenfeld, sashank Reviewed By: alangenfeld, sashank Subscribers: max Differential Revision: https://dagster.phacility.com/D3810
mgasner
force-pushed
the
maybe-fix-windows-tests
branch
from
edd78aa
to
3646f0f
Compare
mgasner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.