Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalAssetNode #4742

Merged
merged 1 commit into from Sep 7, 2021
Merged

ExternalAssetNode #4742

merged 1 commit into from Sep 7, 2021

Conversation

sryza
Copy link
Contributor

@sryza sryza commented Sep 4, 2021

No description provided.

@sryza sryza requested a review from prha September 4, 2021 00:03
@vercel
Copy link

vercel bot commented Sep 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elementl/dagster/9c26BsqcqaS1ryhf8aCvbZQ8CZY7
✅ Preview: https://dagster-git-asset-graph-host-elementl.vercel.app



@whitelist_for_serdes
class ExternalAssetDefinition(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the name ExternalAssetDefinition in the absence of the asset decorator. Also, since this is internal-facing only, maybe something like ExternalAssetNode?

Just thinking things through: we can no longer assume there exists at most one asset node per repository / asset_key, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking things through: we can no longer assume there exists at most one asset node per repository / asset_key, right?

I think that's right

Copy link
Member

@prha prha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple renaming suggestions

return self.external_repository_data.external_asset_graph_data

def get_external_asset_definition(self, asset_key: AssetKey):
matching = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_external_asset_dependencies / get_external_asset_node?

)


def external_asset_defs_from_defs(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

external_asset_graph_from_pipeline_defs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants