Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental improvements and fixes to tutorial #592

Merged
merged 14 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@mgasner
Copy link
Collaborator

commented Jan 10, 2019

No description provided.

mgasner added some commits Jan 8, 2019

Cp

@mgasner mgasner self-assigned this Jan 10, 2019

@mgasner mgasner requested a review from schrockn Jan 10, 2019

mgasner added some commits Jan 10, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jan 10, 2019

Pull Request Test Coverage Report for Build 30279

  • 45 of 71 (63.38%) changed or added relevant lines in 9 files are covered.
  • 57 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.2%) to 85.263%

Changes Missing Coverage Covered Lines Changed/Added Lines %
python_modules/dagster/dagster/tutorials/intro_tutorial/config.py 9 11 81.82%
python_modules/dagster/dagster/tutorials/intro_tutorial/pipeline_execution.py 0 3 0.0%
python_modules/dagster/dagster/tutorials/intro_tutorial/configuration_schemas.py 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
python_modules/dagster/dagster/core/types/builtin_config_schemas.py 1 95.65%
python_modules/dagit/dagit/schema/roots.py 1 93.65%
python_modules/dagstermill/dagstermill/cli.py 1 75.81%
python_modules/dagit/dagit/schema/model.py 5 86.99%
python_modules/dagster/dagster/core/definitions/pipeline.py 10 84.71%
python_modules/dagstermill/dagstermill/init.py 11 89.51%
python_modules/dagit/dagit/schema/pipelines.py 13 93.73%
python_modules/dagster/dagster/core/types/runtime.py 15 86.99%
Totals Coverage Status
Change from base Build 29952: -0.2%
Covered Lines: 6260
Relevant Lines: 7342

💛 - Coveralls
@schrockn
Copy link
Member

left a comment

great stuff. only thing is question re: double quotes. don't want to thrash everything

Show resolved Hide resolved python_modules/dagster/dagster/tutorials/intro_tutorial/actual_dag.py Outdated
@@ -0,0 +1,38 @@
# encoding: utf-8

This comment has been minimized.

Copy link
@schrockn

schrockn Jan 10, 2019

Member

what's the encoding: thing about?

This comment has been minimized.

Copy link
@mgasner

mgasner Jan 10, 2019

Author Collaborator

py 2.7 compatibility, we could go as deep as we want on this particular horror

This comment has been minimized.

Copy link
@schrockn

schrockn Jan 10, 2019

Member

rgr. comment might be nice


Conceptually, where **inputs** are inputs to the computation done by a single solid, and might be
linked by a dependency definition to **outputs** of a previous computation in a DAG,
**configuration** should be used to specify *how* a computation executes.

This comment has been minimized.

Copy link
@schrockn

schrockn Jan 10, 2019

Member

this is a great explanation 👍🏻

-n define_demo_configuration_schema_pipeline -e configuration_schemas_error_2.yml
...
dagster.core.execution.PipelineConfigEvaluationError: Pipeline "demo_configuration_schema" config errors:
Error 1: Undefined field "double_the_word_with_typed_config" at path root:solids

This comment has been minimized.

Copy link
@schrockn

schrockn Jan 10, 2019

Member

really do ❤️ these error messages

@mgasner mgasner merged commit 3df75e5 into master Jan 10, 2019

22 checks passed

ci/circleci: airline-demo-py27 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py35 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py36 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py37 Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: dagit-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagit-webapp Your tests passed on CircleCI!
Details
ci/circleci: dagster-aux-modules-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-aux-modules-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-aux-modules-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-aux-modules-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py37 Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.