[dagster-io/ui] Make disabled+checked Switch state more obvious #8033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAGIT-30 [toggles] hard to distinguish on vs off state when disabled
Everything is greyed out since i can not interact with the toggles as a VIEWER level user, but i then have to denote on vs off only via the right left position of the toggle. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Before: After:
|
salazarm
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Make it easier to distinguish between checked/unchecked states on disabled Switch components.
I applied a lower opacity to disabled checkbox, star, and switch versions of
Checkbox. Disabled items with a fill color still show that fill color when in a checked state, it's just faded out. See screenshots.How I Tested These Changes
Storybook examples