Load all code artifacts on grpc server startup, not just pipelines/jobs #8040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
alangenfeld
approved these changes
May 24, 2022
Summary: User reported a race condition with partition set loading - we have logic in place to prevent this for jobs/pipelines, but not for the other code artifacts. Fix that by adding a new method that pulls in any lazy code artifacts at grpc server startup time. Test Plan: Add log outputs to validate that partition sets are loaded as soon as the grpc server is started up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
User reported a race condition with partition set loading - we have logic in place to prevent this for jobs/pipelines, but not for the other code artifacts. Fix that by adding a new method that pulls in any lazy code artifacts at grpc server startup time.
Test Plan:
Add log outputs to validate that partition sets are loaded as soon as the grpc server is started up
Summary & Motivation
How I Tested These Changes