[Feature] Enable to specify disks with path (symlink) to device file #8

Merged
merged 4 commits into from Feb 5, 2014

Projects

None yet

3 participants

@jpopelka

Hi Dag,

this feature was originaly requested by Hitachi.

They had noted that:
" On each boot, device names (sdX) may be different
(e.g. reboot after device hot-add or hot-remove).
So, users would like to give e.g. SCSI ID (by-id) instead of
sdX as dstat's argument. However, dstat command cannot accept SCSI ID."

@jpopelka jpopelka Enable to specify disks with path to device file
or with symbolic link to the device file.

For example:
dstat -d -D /dev/vda2
dstat -d -D /dev/disk/by-id/scsi-SATA_Hitachi_HDP7250_GEA534RF3YYMMA-part3
dstat -d -D /dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0-part2
dstat -d -D /dev/disk/by-uuid/6df45ed6-c4ad-4054-955d-b15102f2c566
eb73336
@dagwieers
Owner

I like the functionality, but this should really be moved out of the Options class and into a function that is called in the init() of the plugin.

@jpopelka

Hi Dag,

I've added a few commits (not sure you've been automatically notified).

Jiri

@dagwieers
Owner

Still need to look at this when I have more time. I am sorry :-/

@dagwieers dagwieers was assigned Nov 30, 2013
@scottchiefbaker
Collaborator

This looks pretty straight-forward, it seems like a good addition.

@dagwieers dagwieers merged commit ab2541b into dagwieers:master Feb 5, 2014
@dagwieers
Owner

Agreed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment