Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Reposync fixes #28

Merged
merged 2 commits into from

4 participants

@ghost

A couple of fixes for reposync support. One option being passed was not present on RHEL5, but wasn't really needed. The other was using the wrong logic for an option.

@tranky

For debugging purposes, I suggest the dryrun flag passed on the reposync section to effectively run the reposync command (with the "--urls" option, already present), rather than printing the raw command that would be executed.

@zyv
Collaborator

@tranky: you mean always run reposync like in

-    ret = run("%s %s -t -c '%s' -r %s -p '%s'" % \
-              (cf.cmd['reposync'], opts, reposync_conf_file, reponame, path))
+    ret = run("%s %s -t -c '%s' -r %s -p '%s'" % \
+              (cf.cmd['reposync'], opts, reposync_conf_file, reponame, path),
+               dryrun=True)

Can this be tested and added to the pull request please?

@tranky

@zyv: exactly as I meant, tested and verified.

@dagwieers dagwieers merged commit b53d52a into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 3 deletions.
  1. +1 −3 mrepo
View
4 mrepo
@@ -1469,11 +1469,9 @@ def mirrorreposync(url, path, reponame):
opts = opts + ' --urls'
if cf.reposynccleanup:
opts = opts + ' --delete'
- if not cf.reposyncnewestonly:
+ if cf.reposyncnewestonly:
opts = opts + ' --newest-only'
- opts = opts + ' --norepopath'
-
# store a temporary YUM config to use with reposync
reposync_conf_contents = """[%s]
name=%s
Something went wrong with that request. Please try again.