Reposync fixes #28

Merged
merged 2 commits into from Jan 26, 2012

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Sep 27, 2011

A couple of fixes for reposync support. One option being passed was not present on RHEL5, but wasn't really needed. The other was using the wrong logic for an option.

tranky commented Sep 27, 2011

For debugging purposes, I suggest the dryrun flag passed on the reposync section to effectively run the reposync command (with the "--urls" option, already present), rather than printing the raw command that would be executed.

Collaborator

zyv commented Sep 27, 2011

@tranky: you mean always run reposync like in

-    ret = run("%s %s -t -c '%s' -r %s -p '%s'" % \
-              (cf.cmd['reposync'], opts, reposync_conf_file, reponame, path))
+    ret = run("%s %s -t -c '%s' -r %s -p '%s'" % \
+              (cf.cmd['reposync'], opts, reposync_conf_file, reponame, path),
+               dryrun=True)

Can this be tested and added to the pull request please?

tranky commented Sep 28, 2011

@zyv: exactly as I meant, tested and verified.

@dagwieers dagwieers added a commit that referenced this pull request Jan 26, 2012

@dagwieers dagwieers Merge pull request #28 from parsonsa/reposync_fixes
Reposync fixes
b53d52a

@dagwieers dagwieers merged commit b53d52a into dagwieers:master Jan 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment