Remove PowerShell v2 support. #427

rkeithhill · 2017-02-18T19:34:58Z

Also doing some miscellaneous cleanup (remove Invoke-NullCoalescing, remove testDebugHarness.ps1 in favor of using the Pester Tests debug configuration, rename CheckVersion.ps1 to CheckRequirements.ps1).

Checkout the version number (1.0.0-pre00) in the chocolatey/poshgit.nuspec file. Not sure which version of NuGet is being used but if v2, I think the prelease string uses a simple lexicographic sort so that pre10 would sort below pre9. I suspect 1.0 could have more than 10 prerelease choco drops. I hope not more than 100 though. :-)

cc #163

Also doing some miscellaneous cleanup (remove Invoke-NullCoalescing, remove testDebugHarness.ps1 in favor of using the Pester Tests debug configuration, rename CheckVersion.ps1 to CheckRequirements.ps1).

dahlbyk

I think we can remove a few more exported functions:

Enable-GitColors
Get-AliasPattern
Get-GitBranch (data exposed through Get-GitStatus)
Write-Prompt

dahlbyk · 2017-02-19T21:51:30Z

appveyor.yml

@@ -3,7 +3,7 @@ os:

 branches:
  only:
-    - master


We probably want to keep both master and develop. That change may also need to find its way into master (the default branch) for it to take effect (not certain about that).

Ideally there would be a way in appveyor.yml to specify the "current target branch". So if we put in both master and develop will that attempt to build a PR meant for develop on master also? If so, that would likely fail. Then again, I'm a total AppVeyor n00b.

It just means any change in master or develop will be built. We will probably want to add a badge for develop, too.

PRs are built regardless of target; this setting is (ideally) only for merged PRs.

dahlbyk · 2017-02-19T22:08:19Z

src/posh-git.psd1


 # Version number of this module.
-ModuleVersion = '0.7.0'
+ModuleVersion = '1.0.0'


Really wish this supported a prerelease suffix. I'd like to be able to differentiate between folks using a PowerShell Gallery version and this branch. Maybe use 1.0.0.0 and then switch to 1.0.0 when the time comes to release?

'1.0.0' comes out as version 1.0.0.-1 so the order between release and pre is wrong. :-(
We can add a field to the module manifest private data to indicate a PrereleaseVersion string that we could retrieve with (gmo posh-git).PrivateData.PSData.PrereleaseVersion.

I am mostly concerned with the issue template version script showing a difference between loading from develop/master and from Chocolatey or the Gallery.

An alternative would be to include the posh-git module's path, perhaps with a replacement of $Home with ~?

'1.0.0' comes out as version 1.0.0.-1 so the order between release and pre is wrong.

It may actually be desirable for a local version (think fork with personalized features) to win out over an official version (e.g. inherited from GitHub Desktop). Maybe? Of course the personalized fork could just bump the version...

The way I handle that scenario is to import by path e.g:

Import-Module $Home\GitHub\dahlbyk\posh-git\src\posh-git.psd1

Development is in the works for PowerShellGet/PSGallery to support prereleases. I'm hoping this problem will get solved in the coming months. PowerShell/PowerShell-RFC#42

Yes, but doing that if posh-git has already been loaded, e.g. in the GitHub Desktop shell, leaves you with two posh-git modules loaded. If one of those is 0.7.0 and the other is a personal fork that also reports 0.7.0, I have to check path to differentiate. Thus my suggestion of the extra .0 as a hint that this isn't an official version.

That said, also including PrereleaseVersion makes sense… add that to the issue template script?

OK. But I'll update the issue template file on master in a separate PR. Also, regarding those extra commands to not export. I'll remove those. I'm guilty of adding Get-GitBranch for testing purposes but I think Pesters's InModuleScope will get me access to this function.

What if we leave in Write-Prompt to abstract the difference between using Write-Host and ANSI escape sequences. Folks customizing their own prompt function might find that useful.

dahlbyk · 2017-02-19T22:59:19Z

src/posh-git.psd1

@@ -50,7 +49,7 @@ CmdletsToExport = @()
 VariablesToExport = @()

 # Aliases to export from this module
-AliasesToExport = @('??')
+AliasesToExport = @()


Remove until we stumble on an alias we want to export (unlikely)?

An empty array helps with overall system performance.

If you omit the entry, PowerShell does more expensive work to see if you meant to export any aliases.

dahlbyk · 2017-02-19T23:01:03Z

chocolatey/poshgit.nuspec

@@ -3,7 +3,7 @@
  <metadata>
    <id>poshgit</id>
    <title>posh-git</title>
-    <version>0.7.0</version>
+    <version>1.0.0-pre00</version>


Also add PrereleaseVersion as module private data property. Might come in handy. I'll update the issue template on master and then submit a PR to merge master to develop.

dahlbyk · 2017-02-20T06:11:43Z

So build is green here, but failed on develop. @rkeithhill can you take a look?

rkeithhill · 2017-02-20T06:14:09Z

Yup. Could be the switch to using InModuleScope to access the Get-GitBranch function (as opposed to exporting it).

dahlbyk · 2017-02-20T06:20:44Z

Could be the switch to using InModuleScope to access the Get-GitBranch function (as opposed to exporting it).

I wouldn't expect that to have passed in the PR build. My guess is it's due to building on develop instead of master?

rkeithhill · 2017-02-20T06:29:34Z

Was just looking more closely at the error messages. It doesn't like creating #develop. I wouldn't think that would interfere with the existing develop branch.

rkeithhill · 2017-02-20T06:50:03Z

I can run these tests locally on both master and develop and they all pass. This must have something to do with how AppVeyor sets up the build/test environment. For instance, when it uses develop, I see failures like this:

        Expected exactly: {master}

        But was: {}

Is it fetching develop only and not master as well?

dahlbyk · 2017-02-20T06:51:32Z

Context 'Fetch/Push/Pull TabExpansion Tests' doesn't use a test repo; it's using the posh-git repo. I get the same set of failures if I delete my local master branch. PR incoming.

rkeithhill · 2017-02-20T06:53:20Z

Yeah, my bad. Thanks for the help on this!

dahlbyk · 2017-02-20T06:56:26Z

PR opened into master. I'll open another PR from master into develop when this is merged.

rkeithhill added this to the v1.0 milestone Feb 18, 2017

rkeithhill requested a review from dahlbyk February 18, 2017 19:34

Remove PowerShell v2 support.

cf148fd

Also doing some miscellaneous cleanup (remove Invoke-NullCoalescing, remove testDebugHarness.ps1 in favor of using the Pester Tests debug configuration, rename CheckVersion.ps1 to CheckRequirements.ps1).

rkeithhill force-pushed the rkeithhill/remove-PS2.0-support branch from 52e7296 to cf148fd Compare February 18, 2017 21:34

rkeithhill mentioned this pull request Feb 18, 2017

Prepare for 1.0 development #418

Closed

dahlbyk requested changes Feb 19, 2017

View reviewed changes

rkeithhill and others added 4 commits February 19, 2017 19:03

Add master as AppVeyor branch.

b4165df

Also add PrereleaseVersion as module private data property. Might come in handy. I'll update the issue template on master and then submit a PR to merge master to develop.

Change case to be more readable.

4026378

Update CHANGELOG.md

28c3bba

Don't exp Get-AliasPattern/GitBranch, En-GitColors

d4b1669

dahlbyk approved these changes Feb 20, 2017

View reviewed changes

dahlbyk added 2 commits February 19, 2017 23:49

README formatting

1241644

Update CHANGELOG.md

6b2d854

dahlbyk merged commit 05fc072 into develop Feb 20, 2017

dahlbyk deleted the rkeithhill/remove-PS2.0-support branch February 20, 2017 06:03

This was referenced Feb 20, 2017

Invoke-NullCoalescing lies #93

Closed

Switch PSD1 to use RootModule for 1.0.0 release #346

Closed

rkeithhill mentioned this pull request Feb 20, 2017

Capture moduleBase/prerelease in Issue Template. #430

Merged

dahlbyk mentioned this pull request Feb 20, 2017

Ensure master exists for tests that require it #431

Merged

This was referenced Feb 22, 2017

Various v0.7.1 adjustments #436

Merged

Update develop from master #437

Merged

rkeithhill mentioned this pull request Dec 1, 2018

Function Get-GitBranch is missing from posh-git 1.0 #646

Closed

dahlbyk mentioned this pull request Dec 13, 2022

Bring back Get-GitBranch #935

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove PowerShell v2 support. #427

Remove PowerShell v2 support. #427

rkeithhill commented Feb 18, 2017 •

edited by dahlbyk

dahlbyk left a comment •

edited

dahlbyk Feb 19, 2017

rkeithhill Feb 20, 2017

dahlbyk Feb 20, 2017

dahlbyk Feb 19, 2017

rkeithhill Feb 20, 2017

dahlbyk Feb 20, 2017

dahlbyk Feb 20, 2017

rkeithhill Feb 20, 2017

dahlbyk Feb 20, 2017

rkeithhill Feb 20, 2017

rkeithhill Feb 20, 2017

dahlbyk Feb 19, 2017

lzybkr Feb 19, 2017

dahlbyk Feb 19, 2017

dahlbyk commented Feb 20, 2017

rkeithhill commented Feb 20, 2017

dahlbyk commented Feb 20, 2017

rkeithhill commented Feb 20, 2017 •

edited

rkeithhill commented Feb 20, 2017

dahlbyk commented Feb 20, 2017

rkeithhill commented Feb 20, 2017

dahlbyk commented Feb 20, 2017

Remove PowerShell v2 support. #427

Remove PowerShell v2 support. #427

Conversation

rkeithhill commented Feb 18, 2017 • edited by dahlbyk

dahlbyk left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dahlbyk commented Feb 20, 2017

rkeithhill commented Feb 20, 2017

dahlbyk commented Feb 20, 2017

rkeithhill commented Feb 20, 2017 • edited

rkeithhill commented Feb 20, 2017

dahlbyk commented Feb 20, 2017

rkeithhill commented Feb 20, 2017

dahlbyk commented Feb 20, 2017

rkeithhill commented Feb 18, 2017 •

edited by dahlbyk

dahlbyk left a comment •

edited

rkeithhill commented Feb 20, 2017 •

edited