Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ruby/rb/rt tags to div #1

Merged
merged 2 commits into from Dec 18, 2019
Merged

Replace ruby/rb/rt tags to div #1

merged 2 commits into from Dec 18, 2019

Conversation

@item4
Copy link
Contributor

item4 commented Dec 18, 2019

Firefox enforce height of rb and rt, and it can not patch by
!important flag. To fix wrong render between each browsers, I
can not use ruby tag and use div commonly. I considered also
display: ruby, but Firefox only supports that and others
does not. This commit(and PR) make header same at each browsers.

item4 added 2 commits Dec 18, 2019
Firefox enforce height of rb and rt, and it can not patch by
`!important` flag. To fix wrong render between each browsers, I
can not use ruby tag and use div commonly. I considered also
`display: ruby`, but Firefox only supports that and others
does not. This commit(and PR) make header same at each browsers.
1. Rollback contents in `<h1>`. It will keep symantic.
2. Add new JavaScript codes to replace contents in `<h1>` to
   pritty display markup.
@dahlia dahlia merged commit e037eaa into dahlia:master Dec 18, 2019
@dahlia

This comment has been minimized.

Copy link
Owner

dahlia commented Dec 18, 2019

Thanks for your help! 🙏

@item4 item4 deleted the item4:markup branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.