Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrong comparison and saving a sorted set #3

Merged
merged 1 commit into from Mar 10, 2013
Merged

Conversation

@Kroisse
Copy link
Contributor

@Kroisse Kroisse commented Mar 10, 2013

if session.server_version < (2, 4, 0):

This comparison is always True because the type of session.server_version is str, so comparing it with a tuple would be affected by this rule.

dahlia added a commit that referenced this pull request Mar 10, 2013
Fix a wrong comparison and saving a sorted set
@dahlia dahlia merged commit 31c96e7 into dahlia:master Mar 10, 2013
1 check passed
1 check passed
@dahlia
default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants