New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing incrementation in sider.list.List.__iter__() #6

Merged
merged 1 commit into from Mar 21, 2013

Conversation

2 participants
@Kroisse
Contributor

Kroisse commented Mar 21, 2013

This function have fetched a few items of the list that is too long to be fetched at once. Furthermore, this code used the trick to calling Session.mark_query() in the loop and prevent to calling it more than once. But it doesn't need to do because mark_query() was called exactly one time in the all situation. So I fixed it too.

Fix missing incrementation in sider.list.List.__iter__()
This function have fetched a few items of the list that is too long
to be fetched at once. Furthermore, this code used the trick to calling
`Session.mark_query()` in the loop and prevent to calling it more than once.
But it doesn't need to do because `mark_query()` was called exactly one time
in the all situation. So I fixed it too.

dahlia added a commit that referenced this pull request Mar 21, 2013

Merge pull request #6 from Kroisse/fix-list
Fix missing incrementation in sider.list.List.__iter__()

@dahlia dahlia merged commit 6c82f8b into dahlia:master Mar 21, 2013

1 check passed

default The Travis build passed
Details

@Kroisse Kroisse deleted the Kroisse:fix-list branch Mar 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment