Added a modulate API method wrapper and tests. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to change the hue of an image using wand and found that in order to do so, I would have to use the low level API. Rather than do that (and recreate the wheel) I decided to try and add support in the image module for wand directly. It was relatively straightforward and I did a little hand functional test with the mona lisa PNG from wikipedia.
I decided to contribute this as I thought there might be other people out there who needed to use ImageMagick's modulate method. So, I read the contributor docs and created a test case and docstrings for my new method. If I need to do anything else to get this patch included, please let me know. I tried to follow the project standards as closely as I could.
Thanks,
Dan