comms: standardize formatting, improve comments #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
capt-t
commented
Jul 19, 2020
capt-t
commented
- remove ; at EOL
- indent anonymous functions
- improve a few comments
- rename two loop variables
daid
reviewed
Jul 20, 2020
scripts/comms_ship.lua
Outdated
| for n=0,shields-1 do | ||
| msg = msg .. "Shield " .. n .. ": " .. math.floor(comms_target:getShieldLevel(n) / comms_target:getShieldMax(n) * 100) .. "%\n" | ||
| addCommsReply( | ||
| "Report status", |
There was a problem hiding this comment.
I don't like this style, I find it much less readable.
|
(The style settings were consistent with all the other early scenarios. I do not call the style with Nevertheless, this is a reduced version of the original commit. |
olivier-vm
pushed a commit
to olivier-vm/EmptyEpsilon-Clones
that referenced
this pull request
Oct 17, 2021
comms: standardize formatting, improve comments
olivier-vm
added a commit
to olivier-vm/EmptyEpsilon-Clones
that referenced
this pull request
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.