Skip to content

Oasis 1.1#192

Merged
gbalabasquer merged 34 commits into
masterfrom
kk/oasis-forever
Jan 28, 2021
Merged

Oasis 1.1#192
gbalabasquer merged 34 commits into
masterfrom
kk/oasis-forever

Conversation

@krzkaczor

@krzkaczor krzkaczor commented Jan 4, 2021

Copy link
Copy Markdown
Collaborator

Summary

This PR removes the expiration date from OasisDEX and makes all necessary tweaks to make it run forever!

Changes:

  • Support non-compliant erc20 tokens
  • Remove expiring market
  • Automatically set dust limit using uniswap as price oracle
    • Let anyone set dust limit
    • Decide what to do when token doesn't exist
    • Prevent setting dust for DAI
  • Allow anyone to cancel dust trades

@krzkaczor krzkaczor changed the title Oasis Forever [wip] Oasis Forever Jan 8, 2021
@krzkaczor krzkaczor marked this pull request as ready for review January 8, 2021 15:28
Comment thread src/matching_market.sol
Comment thread src/matching_market.sol
Comment thread src/matching_market.sol
Comment thread src/matching_market.sol Outdated
Comment thread src/matching_market.sol Outdated
Comment thread src/matching_market.sol Outdated
Comment thread src/matching_market.sol
Comment thread scripts/run-live-tests.sh Outdated
Comment thread scripts/run-tests.sh Outdated
Comment thread src/uniswap/UniswapLibrary.sol Outdated
Comment thread src/matching_market.sol
Comment thread src/matching_market.sol Outdated
Comment thread src/matching_market.sol Outdated
Comment thread src/matching_market.t.sol Outdated
@krzkaczor krzkaczor changed the title Oasis Forever Oasis 1.1 Jan 15, 2021
Comment thread src/matching_market.sol Outdated
Comment thread src/matching_market.sol Outdated
Comment thread src/matching_market.sol Outdated
Comment thread README.md Outdated
Comment thread src/matching_market.t.sol Outdated

@gbalabasquer gbalabasquer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When this is going to get merged please use the "Squash and merge" option.

@gbalabasquer gbalabasquer merged commit 3b02ac6 into master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants