Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oasis 1.1 #192

Merged
merged 34 commits into from Jan 28, 2021
Merged

Oasis 1.1 #192

merged 34 commits into from Jan 28, 2021

Conversation

krzkaczor
Copy link
Collaborator

@krzkaczor krzkaczor commented Jan 4, 2021 •
edited

Summary

This PR removes the expiration date from OasisDEX and makes all necessary tweaks to make it run forever!

Changes:

  • Support non-compliant erc20 tokens
  • Remove expiring market
  • Automatically set dust limit using uniswap as price oracle
    • Let anyone set dust limit
    • Decide what to do when token doesn't exist
    • Prevent setting dust for DAI
  • Allow anyone to cancel dust trades

@krzkaczor krzkaczor changed the title Oasis Forever [wip] Oasis Forever Jan 8, 2021
@krzkaczor krzkaczor marked this pull request as ready for review January 8, 2021 15:28
maciejka
maciejka reviewed Jan 11, 2021
View reviewed changes
src/matching_market.sol Show resolved Hide resolved
src/matching_market.sol Show resolved Hide resolved
gbalabasquer
gbalabasquer reviewed Jan 13, 2021
View reviewed changes
scripts/run-tests.sh Outdated Show resolved Hide resolved
@krzkaczor krzkaczor changed the title Oasis Forever Oasis 1.1 Jan 15, 2021
gbalabasquer
gbalabasquer reviewed Jan 18, 2021
View reviewed changes
src/matching_market.sol Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gbalabasquer
gbalabasquer approved these changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@gbalabasquer gbalabasquer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When this is going to get merged please use the "Squash and merge" option.

@gbalabasquer gbalabasquer merged commit 3b02ac6 into master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejka maciejka maciejka left review comments

@gbalabasquer gbalabasquer gbalabasquer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krzkaczor @maciejka @gbalabasquer