Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not enabled for 8.3.3 #93

Closed
donk7413 opened this issue Mar 24, 2022 · 4 comments · Fixed by #94
Closed

Not enabled for 8.3.3 #93

donk7413 opened this issue Mar 24, 2022 · 4 comments · Fixed by #94

Comments

@donk7413
Copy link

I can't use the plugin since N++ 8.3.3. It's disabled.
@dail8859
Copy link
Owner

Notepad++ broke their plugin compatibility and required nearly all plugins to be recompiled. I don't have an ETA when LuaScript will be fixed unless someone creates a PR.

Related to: #92

@cmagnush
Copy link
Contributor

cmagnush commented Mar 26, 2022 •
edited

Just created a draft pull request. Seems to work, though I haven't tested it much (and not at all with files > 2 GB). I'm new to working with Github, so let me know if I should do things differently.

@cmagnush
Copy link
Contributor

Did some quick testing on a big file, and it is not working correctly. I suspect something needs to be done about IFaceTable...

@cmagnush
Copy link
Contributor

Found the problem; I had somehow missed to remove a cast... I updated the pull request (with a bunch of additional fixes), and now it should work with big files.

@dail8859 dail8859 linked a pull request Mar 28, 2022 that will close this issue
Fix NPP 8.3.3 plugin API compatibility #94
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NPP 8.3.3 plugin API compatibility cmagnush/LuaScript
3 participants
@dail8859 @donk7413 @cmagnush