[DAILY-57216] Add the OAuth2 refresh token mechanism #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle request with stacked callbacks
…eturn a proper session in the callback if the user call this function before the SDK initial instanciation end
…o use the internal cookie if present. Fallback to site session loading if no refresh token is available
…iration before calling api
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the refresh token mechanism in the SDK.
The token will be refreshed before any API call if the token is expired.
If a session is not specifically injected during the SDK initialization, the code will try to get the refresh token from the possible available
refresh_tokenneon cookie.Jira: https://jira.dailymotion.com/browse/DAILY-57216
I'n not quite aware yet of all the usage of the SDK elsewhere.
@Amzani @nyvath Could you specifically have a look if this patch could lead to regressions depending on how (and where) the SDK is used on our stack (and also for external public SDK users)?