Skip to content

Commit

Permalink
Return cli widgets as default if no others are resolved
Browse files Browse the repository at this point in the history
  • Loading branch information
guderkar committed Aug 22, 2022
1 parent 7d5e290 commit 4735efb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 1 addition & 2 deletions src/daipecore/widgets/CommandLineWidgets.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from typing import Optional
from daipecore.widgets.Widgets import Widgets
from argparse import ArgumentParser
from daipecore.detector import is_cli


class CommandLineWidgets(Widgets):
Expand Down Expand Up @@ -46,4 +45,4 @@ def get_value(self, name: str):
return value

def should_be_resolved(self):
return is_cli()
return False
7 changes: 5 additions & 2 deletions src/daipecore/widgets/WidgetsFactory.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
from typing import List
from daipecore.widgets.Widgets import Widgets
from daipecore.widgets.CommandLineWidgets import CommandLineWidgets


class WidgetsFactory:
def __init__(self, widgets: List[Widgets]):
def __init__(self, widgets: List[Widgets], cli_widgets: CommandLineWidgets):
self.__widgets = widgets
self.__cli_widgets = cli_widgets

def create(self) -> Widgets:
for widget in self.__widgets:
if widget.should_be_resolved():
return widget
raise Exception("No widgets resolved")

return self.__cli_widgets

0 comments on commit 4735efb

Please sign in to comment.