Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMAGES folder outside of output folder #33

Closed
clapierre opened this issue Aug 21, 2017 · 2 comments
Closed

IMAGES folder outside of output folder #33

clapierre opened this issue Aug 21, 2017 · 2 comments
Assignees
@rdeltour
Labels
bug
Milestone
Prototype 3

Comments

@clapierre
Copy link

When I tried the following report
ace -o Anesthesia 9780323508902_epub.epub
A Anesthesia directory was created which I was expecting but at the same directory level there was an IMAGES folder created
-rw-r--r--@ 1 charlesl domain users 220724885 Aug 21 13:00 9780323508902_epub.epub
drwxr-xr-x 8 charlesl domain users 272 Aug 21 13:53 Anesthesia
drwxr-xr-x 44 charlesl domain users 1496 Aug 21 13:53 IMAGES

2014-B-032:Elsevier charlesl$ cd Anesthesia/
2014-B-032:Anesthesia charlesl$ ls -l
total 5472
drwxr-xr-x 4 charlesl domain users 136 Aug 21 13:53 IMAGES
-rw-r--r-- 1 charlesl domain users 2785868 Aug 21 13:53 ace.json
drwxr-xr-x 104 charlesl domain users 3536 Aug 21 13:53 data
drwxr-xr-x 4 charlesl domain users 136 Aug 21 13:53 js
-rw-r--r-- 1 charlesl domain users 8991 Aug 21 13:53 report.html

BTW there was no IMAGES directory under data like I saw in another report, so I am confused on where these files are going

I wasn't expecting the IMAGES folder outside of the output folder I specified. Other EPUBs I have tested with didn't have this behavior.
@rdeltour
Copy link
Member

Thank you Charles for the report. I was kinda expecting this could happen in some cases, see #18.

Can you please send me an EPUB sample to reproduce the issue?

@rdeltour rdeltour added the bug label Aug 21, 2017
@rdeltour rdeltour self-assigned this Aug 21, 2017
@rdeltour rdeltour added this to the Prototype 3 milestone Aug 21, 2017
@clapierre
Copy link
Author

Got permission and sent @rdeltour link to EPUB privately.

rdeltour added a commit that referenced this issue Sep 28, 2017
@rdeltour
fix: prevent data to leak outside the report dir
a86fddc 
- Copy relevant EPUB resources (e.g. images) to the report directory
under the `data` subdirectory using the path relative to the EPUB’s
container root, to prevent any leakage.
- Add an integration test for issue #33.

Closes #18, #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
bug
Projects
None yet
Milestone
Prototype 3
Development

No branches or pull requests
2 participants
@rdeltour @clapierre