New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not change "( )" to "rdf:nil" #16

Merged
merged 2 commits into from Oct 21, 2014

Conversation

Projects
None yet
2 participants
@rhmccullough
Contributor

rhmccullough commented Oct 19, 2014

In tests/turtle:

rapper -i turtle -o turtle test-08.ttl

changes "( )" to "rdf:nil".

This change to src/raptor_serialize_turtle.c will produce "( )" in the output file.

do not change "( )" to "rdf:nil"
In tests/turtle:
rapper -i turtle -o turtle test-08.ttl
changes "( )" to "rdf:nil".
This change to src/raptor_serialize_turtle.c will produce "( )" in the
output file.
@dajobe

This comment has been minimized.

Show comment
Hide comment
@dajobe

dajobe Oct 19, 2014

Owner

Can you update the expected test output too so that 'make check' passes? Thanks

Owner

dajobe commented Oct 19, 2014

Can you update the expected test output too so that 'make check' passes? Thanks

@rhmccullough

This comment has been minimized.

Show comment
Hide comment
@rhmccullough

rhmccullough Oct 19, 2014

Contributor

Dave,

  1. As far as I can tell, no test output files are changed.
    I discovered this problem using turtle parser + turtle serializer.
    I don't think any of your tests use this combination.

  2. I still don't have a successful build with GitHub sources
    on Windows8.1/Cygwin.
    What ./configure argument sets MAINTAINER_MODE?
    What is the min. version for bison & perl?
    I have bison 3.0.2 and perl 5.14.2.

Contributor

rhmccullough commented Oct 19, 2014

Dave,

  1. As far as I can tell, no test output files are changed.
    I discovered this problem using turtle parser + turtle serializer.
    I don't think any of your tests use this combination.

  2. I still don't have a successful build with GitHub sources
    on Windows8.1/Cygwin.
    What ./configure argument sets MAINTAINER_MODE?
    What is the min. version for bison & perl?
    I have bison 3.0.2 and perl 5.14.2.

@dajobe

This comment has been minimized.

Show comment
Hide comment
@dajobe

dajobe Oct 19, 2014

Owner

If no test uses this, we should add one. That means adjusting tests/turtle/Makefile.am and adding (git add) the new file under tests/turtle/something.ttl

Use --enable-maintainer-mode like:

$ configure --enable-maintainer-mode

Bison 3.0.2 is the minimum.

Owner

dajobe commented Oct 19, 2014

If no test uses this, we should add one. That means adjusting tests/turtle/Makefile.am and adding (git add) the new file under tests/turtle/something.ttl

Use --enable-maintainer-mode like:

$ configure --enable-maintainer-mode

Bison 3.0.2 is the minimum.

@rhmccullough

This comment has been minimized.

Show comment
Hide comment
@rhmccullough

rhmccullough Oct 20, 2014

Contributor

Dave,

I will fix tests/turtle.

FYI
I can't build on Mac OS X Yosemite.
OS X won't let me install autotools in /usr/local/bin.
I have to put them in /Users/rhm/bin/

Your autogen.sh can't find libtoolize in /Users/rhm/bin.
It does find:
automake
aclocal
autoconf
autoheader

Contributor

rhmccullough commented Oct 20, 2014

Dave,

I will fix tests/turtle.

FYI
I can't build on Mac OS X Yosemite.
OS X won't let me install autotools in /usr/local/bin.
I have to put them in /Users/rhm/bin/

Your autogen.sh can't find libtoolize in /Users/rhm/bin.
It does find:
automake
aclocal
autoconf
autoheader

@dajobe

This comment has been minimized.

Show comment
Hide comment
@dajobe

dajobe Oct 20, 2014

Owner

Homebrew is the thing to use on OSX: http://brew.sh/ it can install all the dependencies you need and manage and update them. I haven't used Yosemite yet, it's too new.

Owner

dajobe commented Oct 20, 2014

Homebrew is the thing to use on OSX: http://brew.sh/ it can install all the dependencies you need and manage and update them. I haven't used Yosemite yet, it's too new.

@rhmccullough

This comment has been minimized.

Show comment
Hide comment
@rhmccullough

rhmccullough Oct 20, 2014

Contributor

Dave and/or Thomas,

I just bought my iMac this year, so my experience is only with
OS X 10.9 and OS X 10.10.

Are you aware that /usr/local/bin is a program, not a directory?
In my Apple developer environment, install succeeds, but the
executables end up in /usr/bin.

In my attempt to install autotools, I used sudo, and the install
appeared to succeed. But there was nothing in /usr/bin.

Contributor

rhmccullough commented Oct 20, 2014

Dave and/or Thomas,

I just bought my iMac this year, so my experience is only with
OS X 10.9 and OS X 10.10.

Are you aware that /usr/local/bin is a program, not a directory?
In my Apple developer environment, install succeeds, but the
executables end up in /usr/bin.

In my attempt to install autotools, I used sudo, and the install
appeared to succeed. But there was nothing in /usr/bin.

@rhmccullough

This comment has been minimized.

Show comment
Hide comment
@rhmccullough

rhmccullough Oct 20, 2014

Contributor

Dave and/or Thomas,

I just installed Homebrew in /usr/local, as recommended.
I changed the owner of /usr/local/homebrew to myself,
leaving group as admin.

I tried ./brew install automake.
It did not link anything into /usr/local/bin.
It did link commands into /usr/local/homebrew/bin.
Apparently I need to add that bin to my PATH.

Outlook.com just threw away several paragraphs I wrote on Mac OS X.
Here's an abridged version of events relevant to raptor.
I did: brew install automake
brew install libtool <= fails because OS X has libtool
but I already installed it in /Users/rhm/bin
brew install autogen
brew search raptor <= error
Used brew autogen:
autogen configure.ac <= lots of errors

Contributor

rhmccullough commented Oct 20, 2014

Dave and/or Thomas,

I just installed Homebrew in /usr/local, as recommended.
I changed the owner of /usr/local/homebrew to myself,
leaving group as admin.

I tried ./brew install automake.
It did not link anything into /usr/local/bin.
It did link commands into /usr/local/homebrew/bin.
Apparently I need to add that bin to my PATH.

Outlook.com just threw away several paragraphs I wrote on Mac OS X.
Here's an abridged version of events relevant to raptor.
I did: brew install automake
brew install libtool <= fails because OS X has libtool
but I already installed it in /Users/rhm/bin
brew install autogen
brew search raptor <= error
Used brew autogen:
autogen configure.ac <= lots of errors

@dajobe

This comment has been minimized.

Show comment
Hide comment
@dajobe

dajobe Oct 20, 2014

Owner

Homebrew doesn't require sudo or changing any use mode. It writes to /usr/local area without extra privileges. Homebrew installs libtoolize as glibtoolize; there is no need for a tool 'libtool'. autogen.sh knows this and works with this. There is no need to install homebrew raptor (which doesn't exist) to build raptor. Just install homebrew without changing any defaults. autogen.sh does not take any arguments. just run ./autogen.sh.

Owner

dajobe commented Oct 20, 2014

Homebrew doesn't require sudo or changing any use mode. It writes to /usr/local area without extra privileges. Homebrew installs libtoolize as glibtoolize; there is no need for a tool 'libtool'. autogen.sh knows this and works with this. There is no need to install homebrew raptor (which doesn't exist) to build raptor. Just install homebrew without changing any defaults. autogen.sh does not take any arguments. just run ./autogen.sh.

@rhmccullough

This comment has been minimized.

Show comment
Hide comment
@rhmccullough

rhmccullough Oct 20, 2014

Contributor

on Mac OS X Yosemite: master branch
After consulting with Homebrew maintainers, I removed the /usr/local/bin PROGRAM, which I think was installed by Xcode. Then I did a normal install of Homebrew in /usr/local. Then
brew install automake
brew install libtool
brew install gtk-doc
brew install bison
cd /usr/local/Cellar/bison/3.0.2/bin; ln -s $PWD/bison /usr/local/bin/
cd; cd github/raptor/raptor
./autogen.sh <= success
make <= rapper success, but DOC Building HTML fails
I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/html/chunk.xsl
make install <= rapper success, but DOC Building HTML fails

Bottom line: I can now install rapper on Windows8.1/Cygwin and Mac OS X Yosemite.

Contributor

rhmccullough commented Oct 20, 2014

on Mac OS X Yosemite: master branch
After consulting with Homebrew maintainers, I removed the /usr/local/bin PROGRAM, which I think was installed by Xcode. Then I did a normal install of Homebrew in /usr/local. Then
brew install automake
brew install libtool
brew install gtk-doc
brew install bison
cd /usr/local/Cellar/bison/3.0.2/bin; ln -s $PWD/bison /usr/local/bin/
cd; cd github/raptor/raptor
./autogen.sh <= success
make <= rapper success, but DOC Building HTML fails
I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/html/chunk.xsl
make install <= rapper success, but DOC Building HTML fails

Bottom line: I can now install rapper on Windows8.1/Cygwin and Mac OS X Yosemite.

@rhmccullough

This comment has been minimized.

Show comment
Hide comment
@rhmccullough

rhmccullough Oct 20, 2014

Contributor

erased -- thought above comment was lost -- it was just moved off my screen.

Contributor

rhmccullough commented Oct 20, 2014

erased -- thought above comment was lost -- it was just moved off my screen.

@dajobe

This comment has been minimized.

Show comment
Hide comment
@dajobe

dajobe Oct 20, 2014

Owner

you don't need doc building; you can use ./autogen.sh --disable-gtk-doc

Owner

dajobe commented Oct 20, 2014

you don't need doc building; you can use ./autogen.sh --disable-gtk-doc

add tests for rdf-nil
test-08.ttl is valid test, but output is not saved => no change
for test of exact syntax, add files test-39.ttl and test-39-out.ttl
modify Makefile.am for these two new files
non staged changes are just dos2unix conversions
@rhmccullough

This comment has been minimized.

Show comment
Hide comment
@rhmccullough

rhmccullough Oct 21, 2014

Contributor

Today's commit to rdf-nil branch completes test changes.
"exact syntax" is called "exact serialization output" in Makefile.am.

Contributor

rhmccullough commented Oct 21, 2014

Today's commit to rdf-nil branch completes test changes.
"exact syntax" is called "exact serialization output" in Makefile.am.

@dajobe

This comment has been minimized.

Show comment
Hide comment
@dajobe

dajobe Oct 21, 2014

Owner

Looks good to me. The tests all pass including the new one.

Owner

dajobe commented Oct 21, 2014

Looks good to me. The tests all pass including the new one.

dajobe added a commit that referenced this pull request Oct 21, 2014

Merge pull request #16 from rhmccullough/rdf-nil
do not change "( )" to "rdf:nil"

@dajobe dajobe merged commit 899a713 into dajobe:master Oct 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rhmccullough rhmccullough deleted the rhmccullough:rdf-nil branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment