Fix error: module 'os' has no attribute 'mkdirs'#60
Merged
daknob merged 2 commits intodaknob:masterfrom Oct 16, 2017
c-w:bugfix/mkdirs
Merged
Fix error: module 'os' has no attribute 'mkdirs'#60daknob merged 2 commits intodaknob:masterfrom c-w:bugfix/mkdirs
daknob merged 2 commits intodaknob:masterfrom
c-w:bugfix/mkdirs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, the
initialize_backendmethod fails with the error being silently swallowed by the broad except block.In order to avoid these sorts of exception masking issues going forward, commit ff68452 also removes the except blocks that wrap the
os.makedirscalls in favor of theexist_okflag so that the only exceptions that get ignored are ones related to the directory already existing. Theexist_okargument was added in Python 3.2 (source). Given that this project supports Python 3.5+, it should be fine to use this flag.