Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.IllegalStateException: Illegal state ACTIVE when running integration tests #443

Closed
dakrone opened this issue Mar 25, 2018 · 1 comment
Assignees
Labels

Comments

@dakrone
Copy link
Owner

@dakrone dakrone commented Mar 25, 2018

When running the integration tests, this ERROR is currently logged:

[2018-03-24T21:40:15,344][ERROR][o.a.h.i.n.c.InternalHttpAsyncClient] I/O reactor terminated abnormally
java.lang.IllegalStateException: Illegal state ACTIVE
	at org.apache.http.util.Asserts.check(Asserts.java:46) ~[httpcore-4.4.9.jar:4.4.9]
	at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor.execute(AbstractMultiworkerIOReactor.java:313) ~[httpcore-nio-4.4.6.jar:4.4.6]
	at org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager.execute(PoolingNHttpClientConnectionManager.java:194) ~[httpasyncclient-4.1.3.jar:4.1.3]
	at clj_http.conn_mgr.proxy$org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager$ReuseableAsyncConnectionManager$fff3515b.execute(Unknown Source) ~[?:?]
	at org.apache.http.impl.nio.client.CloseableHttpAsyncClientBase$1.run(CloseableHttpAsyncClientBase.java:64) [httpasyncclient-4.1.3.jar:4.1.3]
	at java.lang.Thread.run(Thread.java:844) [?:?]

It would be good to investigate what is causing this bad behavior.

@dakrone dakrone added bug 3.x 4.x labels Mar 25, 2018
@dakrone dakrone self-assigned this Mar 25, 2018
@dakrone

This comment has been minimized.

Copy link
Owner Author

@dakrone dakrone commented Mar 25, 2018

Here's an example test that causes the failure: lein test :only clj-http.test.client-test/t-with-async-pool

@dakrone dakrone closed this in 1001815 Mar 28, 2018
dakrone added a commit that referenced this issue Mar 28, 2018
This commit drastically changes the way `with-async-connection-pool` works.
Previously we relied on creating a fake client and and starting to start the
io-reactor, and used a custom `:pooling-info` or `*pooling-info*` to do
poor man's reference counting for shutting down the pool.

No longer, this is now simplified and relies on the user managing scope
themselves.

Resolves #443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.