Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SSLGenericSocketFactory to accept an empty context #426

Merged
merged 1 commit into from Feb 2, 2018

Conversation

@quoll
Copy link
Contributor

quoll commented Jan 31, 2018

See issue #425.

Chose to accept a nil argument to SSLGenericSocketFactory, so as to avoid changing the function interface that is implied in make-socks-proxied-conn-manager.

Using a let block to create the argument for the proxy, so that it's set outside of the call to a macro.

@dakrone dakrone merged commit 8b45606 into dakrone:master Feb 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dakrone

This comment has been minimized.

Copy link
Owner

dakrone commented Feb 2, 2018

Merged, thanks @quoll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.