Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart async #432

Merged
merged 6 commits into from Feb 14, 2018
Merged

Multipart async #432

merged 6 commits into from Feb 14, 2018

Conversation

@grinderrz
Copy link
Contributor

grinderrz commented Feb 12, 2018

Attempt to fix #431
See also apache/httpcomponents-client#36

@dakrone

This comment has been minimized.

Copy link
Owner

dakrone commented Feb 13, 2018

@grinderrz thanks for submitting this, can you resolve the conflicts before I merge it?

@dakrone dakrone added bug 3.x 4.x labels Feb 13, 2018
@grinderrz

This comment has been minimized.

Copy link
Contributor Author

grinderrz commented Feb 13, 2018

It seems, that the bug is already fixed in master and there is no need to bump versions of httpclient and httpmime.
So this PR is only adding test and may be considered optional.

@dakrone

This comment has been minimized.

Copy link
Owner

dakrone commented Feb 14, 2018

Okay, it's great to have a test, thanks @grinderrz!

@dakrone dakrone merged commit 564cfa0 into dakrone:master Feb 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dakrone added a commit that referenced this pull request Feb 14, 2018
* fix multipart+async

* tmp version

* revert version

* fix import & docstring

* revert deps version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.