Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirects to an empty location #435

Merged
merged 1 commit into from Feb 21, 2018
Merged

Fix redirects to an empty location #435

merged 1 commit into from Feb 21, 2018

Conversation

@dakrone
Copy link
Owner

dakrone commented Feb 21, 2018

In some cases a server can respond with a redirect to an invalid location (like
"https:///"). With an async request, this leads to the request hanging forever.

This adds an option to do rudimentary validation of the redirect host in the
redirect stragety itself, with an option (:validate-redirects) to turn it off.

Resolves #416

In some cases a server can respond with a redirect to an invalid location (like
"https:///"). With an async request, this leads to the request hanging forever.

This adds an option to do rudimentary validation of the redirect host in the
redirect stragety itself, with an option (`:validate-redirects`) to turn it off.

Resolves #416
@dakrone dakrone added bug 3.x 4.x labels Feb 21, 2018
@dakrone dakrone merged commit 74d24b5 into master Feb 21, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.