Skip to content

Fix performance regression related to #528 - #546

Merged
rymndhng merged 1 commit into
dakrone:3.xfrom
frenchy64:issue-528-fix-regression
Jul 7, 2020
Merged

rymndhng merged 1 commit into
dakrone:3.xfrom
frenchy64:issue-528-fix-regression

Conversation

@frenchy64

@frenchy64 frenchy64 commented Jul 2, 2020 •

Copy link
Copy Markdown
Contributor

As explained here the previous fix for #528 was reverted, possible because of a bad merge.

This PR resolves the performance warning in same way as before: #532

@rymndhng

rymndhng commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

Thank you!

That was my bad for re-introducing the performance regression. 🤦

I'll look into adding lein check as part of the CI process to detect these sooner.

@rymndhng
rymndhng merged commit 4b22f0f into dakrone:3.x Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants