Skip to content

Fix performance regression related to #528 #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2020
Merged

Fix performance regression related to #528 #546

merged 1 commit into from
Jul 7, 2020

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Jul 2, 2020 •
edited
Loading

As explained here the previous fix for #528 was reverted, possible because of a bad merge.

This PR resolves the performance warning in same way as before: #532

@rymndhng
Copy link
Collaborator

rymndhng commented Jul 7, 2020

Thank you!

That was my bad for re-introducing the performance regression. 🤦

I'll look into adding lein check as part of the CI process to detect these sooner.

@rymndhng rymndhng merged commit 4b22f0f into dakrone:3.x Jul 7, 2020
@rymndhng rymndhng mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frenchy64 @rymndhng